Re: [PATCH 0/4] tracing: event filtering v2

From: Ingo Molnar
Date: Sun Mar 22 2009 - 15:56:49 EST



* Tom Zanussi <tzanussi@xxxxxxxxx> wrote:

> Hi,
>
> This is version 2 of my patchset adding filtering to the
> event-tracing infrastructure.
>
> Changes from the previous version:
>
> - added common_ prefix to the 5 common event fields
> - ring_buffer_event_discard() fixes from Steven Rostedt
> - changed 'and' and 'or' for compound filters to '&&' and '||'
> - fixed a bug in the matching logic
>
> Everything seems to work ok for me, but I haven't yet gotten
> around to changing the awkward UI. I plan to fix that as soon as
> I can i.e. allow complete compound expressions to be specified all
> at once, add <, >, <=, >= and parens, etc. Until then, it should
> hopefully be usable for basic filtering.

Thanks Tom - Frederic and me had a good look and i picked them up
into tip:tracing/filters for now and lets see how they hold up in
testing. There was one boundary-condition bug Frederic noticed, i
fixed that.

The subsystem level filters are a nice touch. We still have to
complete and organize events into a comprehensive, Linux-wide set of
tracepoints, so there will be some churn in this area.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/