Re: [git-pull -tip] x86: cleanup patches 20090322

[Jaswinder Singh Rajput]

On Mon, 2009-03-23 at 11:35 +0100, Hannes Eder wrote:
> On Mon, Mar 23, 2009 at 10:45 AM, Jaswinder Singh Rajput
> <jaswinder@xxxxxxxxxx> wrote:
> > On Mon, 2009-03-23 at 18:45 +1030, Rusty Russell wrote:
> >> On Monday 23 March 2009 07:22:56 Jaswinder Singh Rajput wrote:
> >> >       x86: e820.h fix various signedness issues in setup.c and e820.c
> >>
> >> Wouldn't fixing the users be better than changing the header?  Esp. since
> >> it could well now cause similar warnings in userspace programs.
> >>
> >> >  struct e820map {
> >> > -   __u32 nr_map;
> >> > +   __s32 nr_map;
> >> >     struct e820entry map[E820_X_MAX];
> >> >  };
> >>
> >> This number can't be negative!
> >>
> >
> > Is this OK, or should I go more further:
> 
> since sanitize_e820_map does only modify its third argument on
> success, and leaves it untouched on error, the temporary variable
> could be eliminated in some places.

OK, this is different issue so I will send this in separate patch.

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/