Re: [PATCH] p54: fix SoftLED compile dependencies

From: John W. Linville
Date: Mon Mar 23 2009 - 10:16:00 EST


On Sat, Mar 21, 2009 at 12:57:46AM +0100, Christian Lamparter wrote:
> This patch fixes a compile problem when the MAC80211_LEDS
> triggers are enabled but not LED class itself.
> (which is sort of pointless, but anyway...)
>
> Signed-off-by: Christian Lamparter <chunkeey@xxxxxx>
> ---
> mb, thank you for the tips!
>
> Randy Dunlap can you please give this patch a try?
>
> John, do you know where the patch form
> Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> went?
> ---
> diff --git a/drivers/net/wireless/p54/Kconfig b/drivers/net/wireless/p54/Kconfig
> index 0e344ac..ee1aaca 100644
> --- a/drivers/net/wireless/p54/Kconfig
> +++ b/drivers/net/wireless/p54/Kconfig
> @@ -1,9 +1,10 @@
> config P54_COMMON
> tristate "Softmac Prism54 support"
> - depends on MAC80211 && WLAN_80211 && FW_LOADER && EXPERIMENTAL
> + depends on MAC80211 && WLAN_80211 && EXPERIMENTAL
> + select FW_LOADER
> ---help---
> - This is common code for isl38xx based cards.
> - This module does nothing by itself - the USB/PCI frontends
> + This is common code for isl38xx/stlc45xx based modules.
> + This module does nothing by itself - the USB/PCI/SPI frontends
> also need to be enabled in order to support any devices.
>
> These devices require softmac firmware which can be found at

This hunk looks unrelated to the changelog as well...?

John
--
John W. Linville Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/