Re: [PATCH 7/7] kmemtrace: update usage ofring_buffer_lock_reserve()

From: Ingo Molnar
Date: Mon Mar 23 2009 - 10:56:25 EST



* Eduard - Gabriel Munteanu <eduard.munteanu@xxxxxxxxxxx> wrote:

> The ring buffer API has changed a bit and kmemtrace wasn't
> compiling anymore. This fixes the issue and allows kmemtrace to
> build.
>
> Signed-off-by: Eduard - Gabriel Munteanu <eduard.munteanu@xxxxxxxxxxx>

hm, kmemtrace was building and working fine in -tip:

[root@aldebaran tracing]# head trace
# tracer: kmemtrace
#
type_id 0 call_site 18446744071565600429 ptr 18446612139794190624
type_id 0 call_site 18446744071565600392 ptr 18446612146227278976
type_id 1 call_site 18446744071564535786 ptr 18446612146228083456
type_id 0 call_site 18446744071565600392 ptr 18446612146240588256
type_id 1 call_site 18446744071564535786 ptr 18446612146240893824

the build error that is fixed by you here was introduced by your
earlier 4/7 patch in this series:

kmemtrace: use tracepoints

So i've backmerged patch 7/7 into patch 4/7. Agreed?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/