Re: USB: serial: add symbol serial driver

[Greg KH]

On Thu, Mar 26, 2009 at 07:42:28PM +0000, Alan Cox wrote:
> On Thu, 26 Mar 2009 19:29:28 GMT
> Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> wrote:
> 
> Thank you for not running this past the tty layer maintainer.

Sorry about that.

> > +	/*
> > +	 * Force low_latency on so that our tty_push actually forces the data
> > +	 * through, otherwise it is scheduled, and with high data rates (like
> > +	 * with OHCI) data can get lost.
> > +	 */
> > +	if (tty)
> > +		tty->low_latency = 1;
> 
> The above is bogus cargo cult programming copied from old drivers and
> should be removed.

It's all over the usb-serial drivers, should I just remove it from all
of them?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/