Re: [PATCH] usb driver for intellon based PLC like devolo dlan duo

[Oliver Neukum]

Am Samstag 18 April 2009 09:16:28 schrieb Peter Holik:

> > +       len = (skb->data[skb->len - 2] | (skb->data[skb->len - 1] << 8));
> >
> > Please use a conversion function.
>
> do you mean
>
> len = le16_to_cpu(skb->data[skb->len - 2] | (skb->data[skb->len - 1] <<
> 8));

Without the "|". Just dereference the pointer.

>   pack_len &= 0x07ff;
>
>   len = (__le16 *) __skb_push(skb, INT51X1_HEADER_SIZE);
>   *len = cpu_to_le16(pack_len);

That's correct.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/