RE: linux-next ia64 build problems in slqb
From: Pekka J Enberg
Date: Wed Apr 22 2009 - 03:02:20 EST
Hi Tony,
On Tue, 21 Apr 2009, Luck, Tony wrote:
> > One minor nit: the patch should define an empty static inline of
> > claim_remote_free_list() for the !SMP case. I can fix it at my end
> > before merging, though, if necessary.
>
> Agreed. It would be better to have an empty static inline than
> adding the noisy #ifdef SMP around every call to
> claim_remote_free_list() ... in fact some such #ifdef can be
> removed.
>
> You could tag such a modified patch (attached) as:
>
> Acked-by: Tony Luck <tony.luck@xxxxxxxxx>
Thanks for the help! I went and merged the following patch and I hope I
got all the patch attributions right. Paul, does this work for you as well?
Pekka