Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled

[David Brownell]

On Thursday 23 April 2009, Alessandro Zummo wrote:
>  Is not an API change, we are gradually relaxing it if it
>  proves workable :)

Erm, it *is* an API change at least to the extent that
the last version of the patch made the interface spec
become incorrect.

Current interface spec *requires* that function to be
called with IRQs disabled.

The downside of that spec is that there's no way to test
it, since CONFIG_LOCKDEP doesn't understand that almost
all IRQ handlers don't disable IRQs.  So there are some
bugs in RTC drivers that can only be uncovered by code
review.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/