Re: [PATCH -tip] remove the BKL: remove "BKL auto-drop" assumption from ext3_remount()
From: Alessio Igor Bogani
Date: Mon Apr 27 2009 - 16:21:52 EST
Dear Sir Molnar,
2009/4/26 Ingo Molnar <mingo@xxxxxxx>:
[...]
>> + unlock_kernel();
>> unlock_super(sb);
>> ext3_mark_recovery_complete(sb, es);
>> lock_super(sb);
>> + lock_kernel();
>
> Shouldnt this be a conditional-unlock, so that if the remount moves
> away from under the BKL we dont break in this place?
[...]
Please excuse me I'm only a stupid howler monkey. :-)
Patch with conditional-unlock/lock follow in a second.
Thank you!
Ciao,
Alessio
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/