Re: [PATCH 07/27] asm-generic: add minimal cache description

[Michal Simek]

Arnd Bergmann wrote:
> On Friday 01 May 2009, Michal Simek wrote:
>>> +#define copy_to_user_page(vma, page, vaddr, dst, src, len) \
>>> +       memcpy(dst, src, len)
>>> +#define copy_from_user_page(vma, page, vaddr, dst, src, len) \
>>> +       memcpy(dst, src, len)
>>
>> IMHO these two macros will generate cast errors.
> 
> I did not see errors here, can you clarify? Note that despite the name,
> they don't take a __user pointer. Maybe they should be inline functions
> to make that more obvious.

you are right here with __user.
x86 use it as inline function.

Michal

> 
> 	Arnd <><


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/