Re: [RFC][PATCH 32/35] Move users to asm-generic/ptemap.h

[Dave Hansen]

On Fri, 2009-05-01 at 13:43 -0400, Christoph Hellwig wrote:
> On Fri, May 01, 2009 at 07:42:51AM -0700, Dave Hansen wrote:
> > Now that we have everyone using pte_offset_kernel(),
> > we can plainy see that almost all the users are
> > exactly the same.
> > 
> > This takes all of those users and moves them over to
> > using asm-generic/ptemap.h instead.
> 
> s/users/implementations/g ?

Yeah, that's clearer.

> Also asm-generic/ptemap.h really wants a comment when architectures
> can use this generic version.

/*
 * If your architecture has direct-mapped PTE pages (no HIGHPTE)
 * then you just need to implement pte_offset_kernel() and include
 * this in your asm/ptemap.h.
 *
 * To support HIGHPTE, you need to have implementations of
 * kmap_atomic_pte() (which usually just calls kmap_atomic()),
 * pmd_page() and pmd_index().
 */


-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/