drivers/scsi/st.c:2967: warning: suggest parentheses around operand of '!' or change '|' to '||' or '!' to '~'

[Geert Uytterhoeven]

drivers/scsi/st.c:2967: warning: suggest parentheses around operand of
'!' or change '|' to '||' or '!' to '~'

        if (cmdstatp->sense_hdr.sense_key == ILLEGAL_REQUEST &&
            !(STp->use_pf & PF_TESTED)) {
                /* Try the other possible state of Page Format if not
                   already tried */
                STp->use_pf = !STp->use_pf | PF_TESTED;
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                st_release_request(SRpnt);
                SRpnt = NULL;
                return st_int_ioctl(STp, cmd_in, arg);
        }

Looks indeed incorrect to me...

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/