Re: [PATCH] xtensa: generalize logic for variant/irq.h inclusion

[Sam Ravnborg]

On Tue, May 05, 2009 at 05:02:14PM +0200, Daniel Glöckner wrote:
> CONFIG_VARIANT_IRQ_SWITCH has been replaced by CONFIG_VARIANT_IRQ_EXT
> and a #define VARIANT_HAS_IRQ_ENABLE in variant/irq.h.
> 
> This change was made to allow further extensions to the irq handling by
> the variant in variant/irq.h independent of the CONFIG_VARIANT_IRQ_SWITCH
> functionality and without forcing all variants to provide this header.
> 
> Signed-off-by: Daniel Glöckner <dg@xxxxxxxxx>
> ---
>  arch/xtensa/Kconfig                              |    4 ++--
>  arch/xtensa/configs/s6105_defconfig              |    2 +-
>  arch/xtensa/include/asm/irq.h                    |    6 ++++--
>  arch/xtensa/variants/s6000/include/variant/irq.h |    1 +
>  4 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/xtensa/Kconfig b/arch/xtensa/Kconfig
> index ac02f3c..76dee02 100644
> --- a/arch/xtensa/Kconfig
> +++ b/arch/xtensa/Kconfig
> @@ -57,7 +57,7 @@ source "kernel/Kconfig.freezer"
>  config MMU
>  	def_bool n
>  
> -config VARIANT_IRQ_SWITCH
> +config VARIANT_IRQ_EXT
>  	def_bool n

Common practice is to name such symbols "HAVE_*".
So in your case:

config HAVE_VARIANT_IRQ_EXT

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/