Re: [PATCH 13/21] amd64_edac: add f10-and-later methods-p3

[Doug Thompson]

--- On Mon, 5/4/09, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote:

> From: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> Subject: Re: [PATCH 13/21] amd64_edac: add f10-and-later methods-p3
> To: "Borislav Petkov" <borislav.petkov@xxxxxxx>
> Cc: akpm@xxxxxxxxxxxxxxxxxxxx, greg@xxxxxxxxx, mingo@xxxxxxx, tglx@xxxxxxxxxxxxx, hpa@xxxxxxxxx, dougthompson@xxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> Date: Monday, May 4, 2009, 5:36 PM
> Borislav Petkov escreveu:
> > From: Doug Thompson <dougthompson@xxxxxxxxxxxx>
> > 
> > Signed-off-by: Doug Thompson <dougthompson@xxxxxxxxxxxx>
> > Signed-off-by: Borislav Petkov <borislav.petkov@xxxxxxx>
> > ---
> >  drivers/edac/amd64_edac.c |  318
> +++++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 318 insertions(+), 0
> deletions(-)
> > 
> > diff --git a/drivers/edac/amd64_edac.c
> b/drivers/edac/amd64_edac.c
> > index fe2342c..84075c0 100644
> > --- a/drivers/edac/amd64_edac.c
> > +++ b/drivers/edac/amd64_edac.c
> > @@ -2726,4 +2726,322 @@ static int
> f10_lookup_addr_in_dct(u32 InputAddr, u32 NodeID, u32
> ChannelSelect)
> >      return CSFound;
> >  }
> >  +/*
> > + * f10_match_to_this_node
> > + *
> > + * For a given 'DramRange' value, check if
> 'SystemAddr' fall within this value
> > + */
> > +static int f10_match_to_this_node(struct amd64_pvt
> *pvt, int DramRange,
> > +       
>         u64 SystemAddr,
> > +       
>         int *node_id,
> > +       
>         int *channel_select)
> > +{
> > +    int CSFound = -1;
> >   
> 
> As in the previous patch, please use a standard error code,
> instead of -1.
> 
> > +static int f10_translate_sysaddr_to_CS(struct
> amd64_pvt *pvt,
> > +       
>     u64 SysAddr,
> > +       
>     int *node,
> > +       
>     int *chanSel)
> > +{
> > +    int DramRange;
> > +    int CSFound = -1;
> >   
> Same here.
> 
> Cheers,
> Mauro
> 

Code was reference code from AMD. Probably safe to convert to use -EINVAL yes

doug t

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/