Re: [PATCH -mmotm] mm: setup_per_zone_inactive_ratio - fix commentand make it __init

[Minchan Kim]

On Wed, 6 May 2009 10:19:23 +0400
Cyrill Gorcunov <gorcunov@xxxxxxxxxx> wrote:

> The caller of setup_per_zone_inactive_ratio is module_init function.

__init :)

> No need to keep the callee after is completed as well.
> Also fix a comment.
> 
> CC: David Rientjes <rientjes@xxxxxxxxxx>
> Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>

Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx>
I guess the comment was a typo. 

> ---
>  mm/page_alloc.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> Index: linux-2.6.git/mm/page_alloc.c
> =====================================================================
> --- linux-2.6.git.orig/mm/page_alloc.c
> +++ linux-2.6.git/mm/page_alloc.c
> @@ -4540,8 +4540,6 @@ void setup_per_zone_pages_min(void)
>  }
>  
>  /**
> - * setup_per_zone_inactive_ratio - called when min_free_kbytes changes.
> - *
>   * The inactive anon list should be small enough that the VM never has to
>   * do too much work, but large enough that each inactive page has a chance
>   * to be referenced again before it is swapped out.
> @@ -4562,7 +4560,7 @@ void setup_per_zone_pages_min(void)
>   *    1TB     101        10GB
>   *   10TB     320        32GB
>   */
> -static void setup_per_zone_inactive_ratio(void)
> +static void __init setup_per_zone_inactive_ratio(void)
>  {
>  	struct zone *zone;
>  
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


-- 
Kinds Regards
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/