Re: [PATCH 10/11] ring-buffer: move big if statement down

[Ingo Molnar]

* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> This patch changes it to a goto:
> 
> 	code;
> 
> 	if (cross to next page)
> 		goto next_page;
> 
> 	more code;
> 
> 	return;
> 
> next_page:
> 
> 	[ lots of code]

I have pulled it, but could you please change it to a helper 
function instead? There's almost never a good reason to combine 
'more code' with 'lots of code' in a single function. It also 
documents the unlikeliness, etc.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/