Re: [PATCH] Yet another Conexant Clone to add to cdc-acm.c

[[6][Mee Ew][Î] !!! -- XKJ || mindless :D]

2009/5/6 Greg KH <gregkh@xxxxxxx>:
> On Wed, May 06, 2009 at 10:47:14PM +0800, [6][Mee Ew][Î] !!! -- XKJ || mindless :D wrote:
>> Dear Mighty Ones,
>>
>> Please be gentle with me. This is my first time...
>>
>> Shiro / Aztech (Singapore) has completely cloned the Conexant USB
>> MODEM RD02-D400 and called it their UM-3100.
>> With the errors, of course.
>>
>> I am trying my best to follow procedures here (as google tells,
>> though), so if I am not right, please feel free to hurl insults back
>> to this mailbox.
>
> Minor thing to change, we need a "Signed-off-by:" line, as per the
> instructions in the file Documentation/SubmittingPatches.
>
> Care to add that to the patch description and resend the whole thing so
> that we can apply it?
>
> thanks,
>
> greg k-h

Understood. I have added you again, this time, because Mr Oliver
Neukum's email bounced on me the last time.

This patch adds another quirky Conexant USB Modem Clone to usb cdc-acm.c

This is to be applied to latest git. (Got off the website...)

Signed-off-by: Xiao Kaijian <xiaokj@xxxxxxxxx>

--- a/drivers/usb/class/cdc-acm.c       2009-05-06 22:06:27.556488116 +0800
+++ b/drivers/usb/class/cdc-acm.c       2009-05-06 22:12:56.648401202 +0800
@@ -1375,6 +1375,13 @@ static struct usb_device_id acm_ids[] = {
       { USB_DEVICE(0x0572, 0x1324), /* Conexant USB MODEM RD02-D400 */
       .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
       },
+       { USB_DEVICE(0x0572, 0x1328), /* Shiro / Aztech USB MODEM UM-3100 */
+        .driver_info = NO_UNION_NORMAL, /* has no union descriptor.
+                                          This is basically a clone of
+                                          Conexant USB MODEM RD02-D400.
+                                          Seems like NO_UNION_ _IS_ becoming
+                                          NORMAL... */
+        },
       { USB_DEVICE(0x22b8, 0x6425), /* Motorola MOTOMAGX phones */
       },
       { USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/