Re: [RFC][PATCH 1/5] PM/Freezer: Disable OOM killer when tasks arefrozen

[Nigel Cunningham]

Hi.

On Thu, 2009-05-07 at 00:41 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@xxxxxxx>
> 
> The OOM killer is not really going to work while tasks are frozen, so
> we can just give up calling it in that case.
> 
> This will allow us to safely use memory allocations for decreasing
> the number of saveable pages in the hibernation core code instead of
> using any artificial memory shriking mechanisms for this purpose.

Should we disable the warning that the nopage path gives if tasks are
frozen? I'm in two minds - if you get problems as a result, it might
help to diagnose them. On the other hand, you don't want tons of
warnings due to the hibernation code trying to allocate memory it can't
get. In TuxOnIce, I currently do all allocations with __GFP_NOWARN.

Regards,

Nigel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/