Re: [PATCH] Double check memmap is actually valid with a memmap has unexpected holes

[Yasunori Goto]

Hi.

> > > +		unsigned long pfn;
> > >  
> > > -		pgdat_resize_lock(pgdat, &flags);
> > 
> > How sure are you about removing the acquisition of this lock?  If anything,
> > it appears that pagetypeinfo_showblockcount_print() should be taking this lock.
> 
> I'm completely unsure about it.
> 
> <adds memory hotplug guys to CC>

zone->zone_start_pfn and zone->spanned_pages may be changed by memory hotplug.
The lock must be acquired before getting their values as Mel-san said.

Thanks.

-- 
Yasunori Goto 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/