Re: [PATCH] msi-x: let drivers retry when not enough vectors

[Michael Ellerman]

On Thu, 2009-05-07 at 03:53 -0600, Matthew Wilcox wrote:
> On Thu, May 07, 2009 at 05:40:15PM +0800, Sheng Yang wrote:
> > It's indeed weird. Why the semantic of pci_enable_msix can be changed to 
> > "enable msix, or tell me how many vector do you have"? You can simply call 
> > pci_msix_table_size() to get what you want, also without any more work, no? I 
> > can't understand...
> 
> Here's a good example.  Let's suppose you have a driver which supports
> two different models of cards, one has 16 MSI-X interrupts, the other
> has 10.  You can call pci_enable_msix() asking for 16 vectors.  If your
> card is model A, you get 16 interrupts.  If your card is model B, it says
> "you can have 10".
> 
> This is less work in the driver (since it must implement falling back to
> a smaller number of interrupts *anyway*) than interrogating the card to
> find out how many interrupts there are, then requesting the right number,
> and still having the fallback path which is going to be less tested.

Not to mention that there's no guarantee that you'll get as many
interrupts as the device supports, so you should really be coding to
cope with that anyway. Like the example in MSI-HOWTO.txt:

197 static int foo_driver_enable_msix(struct foo_adapter *adapter, int nvec)
198 {
199         while (nvec >= FOO_DRIVER_MINIMUM_NVEC) {
200                 rc = pci_enable_msix(adapter->pdev,
201                                      adapter->msix_entries, nvec);
202                 if (rc > 0)
203                         nvec = rc;
204                 else
205                         return rc;
206         }
207 
208         return -ENOSPC;
209 }

So I agree, this patch is an improvement.

cheers

Attachment: signature.asc
Description: This is a digitally signed message part