Re: [PATCH 3/5] tracing/events: add rcu locking around trace eventprints

[Steven Rostedt]

On Thu, 7 May 2009, Ingo Molnar wrote:

> 
> * Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> 
> > Somehow this patch got dropped. I believe Ted's work requires it.
> > 
> > I'm not sure if we need to include rcupdate.h or not to use 
> > rcu_read_lock. I think it may be fine to include it in ftrace.h. 
> > 
> > Jeremy, does this patch effect anything that you are doing?
> > 
> > >  									\
> > > +	rcu_read_lock();						\
> > >  	ret = trace_seq_printf(s, #call ": " print);			\
> > > +	rcu_read_unlock();						\
> > >  	if (!ret)							\
> > >  		return TRACE_TYPE_PARTIAL_LINE;				\
> 
> Hm, this patch adds usage for RCU primitives, but doesnt include 
> rcupdate.h.

Yeah, I thought that would be an issue. Including rcupdate here should not 
be an issue, since the ftrace.h file is only included once, and the 
CREATE_TRACE_POINTS is already undefined.

I'll write up a new patch.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/