Re: [PATCH 3/5] usb,early_printk: insert cr prior to nl as needed

[Ingo Molnar]

* Greg KH <greg@xxxxxxxxx> wrote:

> On Wed, May 06, 2009 at 09:30:25AM +0200, Ingo Molnar wrote:
> > 
> > * Jason Wessel <jason.wessel@xxxxxxxxxxxxx> wrote:
> > 
> > > The rs232 drivers send a carriage return prior to a new line in the
> > > early printk code.
> > > 
> > > The usb debug driver should do the same because you want to be able to
> > > use the same terminal programs and tools for analysis of early printk
> > > data.
> > > 
> > > Signed-off-by: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
> > > ---
> > >  arch/x86/kernel/early_printk.c |   22 ++++++++++++++++------
> > >  1 files changed, 16 insertions(+), 6 deletions(-)
> > 
> > hm, would be better to carry this in the x86 tree - where most of 
> > the early-debug functionality has been authored and maintained. 
> > 
> > Greg, is that fine with you?
> 
> Yes, but it needs a few more rounds to fix the bugs pointed out.  
> So please don't take this one yet.

Sure, will wait for your Acked-by to show up in the changelog.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/