Re: [PATCH 01/14] x86, boot: align the .bss section in thedecompressor

From: Cyrill Gorcunov
Date: Fri May 08 2009 - 03:54:19 EST


[H. Peter Anvin - Thu, May 07, 2009 at 03:26:49PM -0700]
| From: H. Peter Anvin <hpa@xxxxxxxxx>
|
| Aligning the .bss section makes it trivially faster, and makes using
| larger transfers for the clear slightly easier.
|
| [ Impact: trivial performance enhancement, future patch prep ]
|
| Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxx>
| ---
| arch/x86/boot/compressed/vmlinux.lds.S | 1 +
| 1 files changed, 1 insertions(+), 0 deletions(-)
|
| diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S
| index 0d26c92..27c168d 100644
| --- a/arch/x86/boot/compressed/vmlinux.lds.S
| +++ b/arch/x86/boot/compressed/vmlinux.lds.S
| @@ -42,6 +42,7 @@ SECTIONS
| *(.data.*)
| _edata = . ;
| }
| + . = ALIGN(32);
| .bss : {
| _bss = . ;
| *(.bss)
| --
| 1.6.0.6
|

Hi Peter, should not it be ALIGN(8) rather? I thought
we keep these sections as tight as possible in a sake
of limitation of setup code size. Perhaps I miss something.

-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/