Re: [PATCH 2/2] SLUB: Use GFP_PANIC for early-boot allocations

[Peter Zijlstra]

On Fri, 2009-05-08 at 18:36 +0300, Pekka Enberg wrote:
> On Fri, 2009-05-08 at 11:28 -0400, Christoph Lameter wrote:
> > On Fri, 8 May 2009, Pekka Enberg wrote:
> > 
> > > This patch converts SLUB early-boot code to use GFP_PANIC instead of explicit
> > > BUG_ON() calls.
> > 
> > Yirks this is not only early boot code. create_unique_id may be executed
> > whenever a slab is created.
> 
> Argh. We should do -ENOMEM there then. I'll drop that hunk.

BUG_ON((gfp & __GFP_PANIC) && (system_state != STATE_BOOTING));

?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/