Re: [PATCH 2/2] SLUB: Use GFP_PANIC for early-boot allocations

[Peter Zijlstra]

On Fri, 2009-05-08 at 18:45 +0300, Pekka Enberg wrote:

> On Fri, 2009-05-08 at 17:42 +0200, Peter Zijlstra wrote:
> > BUG_ON((gfp & __GFP_PANIC) && (system_state != STATE_BOOTING));
> 
> There's no technical reason not to use GFP_PANIC when system_state !=
> STATE_BOOTING so I don't think it's needed. It's just that GFP_PANIC
> (and BUG_ON) is IMHO too harsh for create_unique_id().

Shouldn't we handle every allocation failure after booting?

I think it _is_ a bug to panic on allocation failures once we're
running.

I'm really not very fond of __GFP_PANIC as it stands, it seems to
suggest its OK to ignore allocation failures, which would bring us back
to the original UNIX error handling :/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/