Re: [PATCH -tip] x86: cpu/proc.c grouping of cpuid in /proc/cpuinfo

[H. Peter Anvin]

Jaswinder Singh Rajput wrote:
> Unification of cpuid_level.
> Also added extended_cpuid_level to make it complete.
> 
> So cpuid* and cpufeature flag come in same group and /proc/cpuinfo
> looks like on AMD box:
> 
> cpuid level     : 1
> ext cpuid level : 0x8000001a
> flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt rdtscp lm 3dnowext 3dnow constant_tsc rep_good nonstop_tsc pni cx16 lahf_lm cmp_legacy svm extapic cr8_legacy 3dnowprefetch osvw skinit
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>

Jaswinder,

/proc/cpuinfo is a userspace API.  You CANNOT change the format of it
without breaking applications.

Therefore, any change which moves flags between fields or removes fields
is unacceptable.  Adding new fields is possible, however.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/