Re: [PATCH] cred: #include init.h in cred.h

[Andrew Morton]

On Tue, 12 May 2009 08:32:31 +1000 (EST)
James Morris <jmorris@xxxxxxxxx> wrote:

> On Mon, 11 May 2009, Andrew Morton wrote:
> 
> > On Sat, 9 May 2009 07:36:52 +0400
> > Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
> > 
> > > linux/cred.h can't be included as first header (alphabetical order)
> > > because it uses __init which is enough to break compilation on some
> > > archs.
> > > 
> > 
> > hm, OK, not a lot of detail there though.
> > 
> > > 
> > > --- a/include/linux/cred.h
> > > +++ b/include/linux/cred.h
> > > @@ -13,6 +13,7 @@
> > >  #define _LINUX_CRED_H
> > >  
> > >  #include <linux/capability.h>
> > > +#include <linux/init.h>
> > >  #include <linux/key.h>
> > >  #include <asm/atomic.h>
> > 
> > I assume that this is needed in 2.6.30?
> > 
> 
> I can see it's in -mm, so might as well go to Linus via there.

No prob.

> Acked-by: James Morris <jmorris@xxxxxxxxx>

Thanks.

This is not the sort of patch which I'd send upstream immediately. 
cred.h is included by sched.h and sched.h doesn't include init.h. 
That's enough uncertainty to require a few days compile-testing..


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/