Re: [PATCH v2] x86: fix ktermios-termio conversion

[Ingo Molnar]

* Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> > hm, on x86 you could use get_user_try / get_user_ex() / 
> > get_user_catch() approach to linearize the dependencies and 
> > reduce register pressure.
> 
> It used *once*, in a path that is never executed except by some 
> ancient binaries. It isn't worth the effort.

i know, and i tested the patch so i know what effects it has.

I never made any argument about inlining, it's obviously correct to 
have a use-once function inline.

My argument was very simple: the patch causes +150 bytes of bloat. 
The try/ex/catch method can help reduce register pressure and can 
reducethe size of code quite visibly.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/