Re: [PATCH 11/12] microblaze: dont include asm/mmu.h in hw_exception_handler

[Arnd Bergmann]

On Tuesday 12 May 2009, Michal Simek wrote:
> 1. Please do not attach your patches - use in-line patches - 
> it is easier for me and for others to review it.

Something went wrong (again...) with my patches this time, so they
got rejected by vger. They are not attached however AFAICT, but
are inline with the "Content-Disposition: inline;" header, which
is generated by "quilt mail". Which tool do you use that does
not work with this correctly?

> - but on the other hand I need mmu.h for mmu patches - because of MICROBLAZE_TLB_SIZE
>   - if you think that mmu.h shouldn't be included we have to
>     move this definition to another file 
>   - you can look at my next branch to see mmu context

Almost all architectures disallow using mmu.h in assembly, only
powerpc and sh have an '#ifndef __ASSEMBLY__' in there. I did the
change to allow using my asm-generic/mmu.h for microblaze-nommu.

When your MMU code gets merged, this is no longer required though,
because you cannot simply fall back on the asm-generic version anyway.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/