Re: [PATCH] swim3: use blk_end_request instead ofblk_update_request

[FUJITA Tomonori]

On Tue, 12 May 2009 17:45:33 +0300
Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote:

> On 05/12/2009 02:29 PM, FUJITA Tomonori wrote:
> > swim3 is the only user of blk_update_request(). Let's use
> > blk_end_request instead of blk_update_request. swim3 doesn't need to
> > update a request manually. 
> 
> 
> > In addition, we can unexport
> > blk_update_request().
> > 
> 
> blk_update_request() was meant for request-based-multi-path, and not for swim3
> please see:
>     32fab448 block: add request update interface
> 
> CC: Kiyoshi Ueda<k-ueda@xxxxxxxxxxxxx>

I see, thanks. Looks like we need to export it but I still think that
the bug fix patch for swim3 is valid and it's better for swim3 to use
blk_end_request().


> I think Tejun Heo was just using that in some recent block layer, transformation.
> Tejun?

At least, there is no users of it in Jens' for-2.6.31.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/