Re: [PATCH] 8250: Don't restore NS16550 mode when console suspendis disabled

[Deepak Saxena]

On May 12 2009, at 15:00, Linus Torvalds was caught saying:
> 
> Hmm. I already applied this, but then after looking closer, I undid that. 
> Why? It looks buggy:
> 
> > -	if (up->capabilities & UART_NATSEMI) {
> > +	if ((up->capabilities & UART_NATSEMI) && 
> > +	     (!uart_console(&up->port) && console_suspend_enabled)) {
> >  		unsigned char tmp;
> 
> Isn't that second test wrong? Should it not be
> 
> 	if ((up->capabilities & UART_NATSEMI) &&
> 		(console_suspend_enabled || !uart_console(&up->port)) {
> 
> instead?

Yep, thinko on my end.

> 	/*
> 	 * Suspend the uart port unless it's a console. 
> 	 *
> 	 * But suspend even consoles if "console_suspend_enabled"
> 	 * is set.
> 	 */
> 	static inline int do_suspend_uart(struct uart_port *port)
> 	{
> 		return console_suspend_enabled || !uart_console(port);
> 	}
> 
> and then make all these things (including the _existing_ cases in 
> uart_suspend_port() use that helper function, rather than writing it out.

Sounds good. Alan?

~Deepak

-- 
In the end, they will not say, "those were dark times,"  they will ask
"why were their poets silent?" - Bertold Brecht

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/