Re: [PATCH] tsc_khz= boot option to avoid TSC calibration variance

From: Ulrich Windl
Date: Wed May 13 2009 - 04:00:52 EST


On 13 May 2009 at 0:42, Thomas Gleixner wrote:

[...]
> I'm fine with the command line option, but I refuse to add some sys/
> thingy which makes us add extra calibration stuff.
>
> Honestly all this is just the futile attempt to fix the flaws of NTP
> via (super)user interaction.

This has nothing to do with flaws in NTP (AFAIK).

>
> Darn, it can not be that hard to adjust the math to do what you think
> it should do. I'm not an expert on that NTP stuff, but blindly
> stuffing the last known value into the kernel and expect that the
> calibration value did not change is nonsense.

Well, the assumption most likely is that if the hardware didn't change, kernel's
calibration results also shouldn't change.

>
> You know the calibration value which created the last known parameters
> and you want an extra interface to inject this last known calibration
> value into the kernel instead of doing the math of adjusting the NTP
> parameters according to the change of calibration values ?

I think, the wole issue is somewhat "cosmetics of statistics": People don't want
to see a "clock frequency hops" after rebooting the machine (and restarting NTP).
Usually there are thermal effects anyway, so what... Maybe it's just about "making
everything perfect". For most people it's "good enough" already probably.

Regards,
Ulrich



>
> Thanks,
>
> tglx
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/