RE: [PATCH] LP3971 PMIC regulator driver

[Marek Szyprowski]

Hello!

On Thu, May 14, 2009 Mark Brown wrote:

> > This patch adds regulator drivers for National Semiconductors LP3971
> PMIC.
> > This LP3971 PMIC controller has 3 DC/DC voltage converters and 5 low
> drop-out
> > (LDO) regulators. LP3971 PMIC controller uses I2C interface.
> >
> > Reviewed-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> 
> This looks basically good, a few comments below but personally I'd be
> inclined to merge this as-is and deal with the remaining issues as
> separate patches so:
> 
> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> 
> It'd be good to also implement list_voltage().

Ok. I will prepare a new patches that will add this functionality and fix
issues reported below.

> > +       if (reg <= BUCK_TARGET_VOL_MAX_IDX)
> > +               val = 1000 * buck_voltage_map[reg];
> > +       else
> > +               val = 0;
> 
> I'd expect some kind of warning to be displayed here?

Right.

> > +       /* Detect LP3971 (initial system control 1 reg is '0x60') */
> > +       ret = lp3971_i2c_read(i2c, LP3971_SYS_CONTROL1_REG, 1, &val);
> > +       if (ret < 0) {
> > +               dev_err(&i2c->dev, "failed to detect device\n");
> > +               goto err_detect;
> > +       }
> > +
> 
> You don't actually appear to check the value you read back here?

Right, I forgot. Now I noticed in the chip spec that some default bits can
be eeprom programmed. I will handle this too.

Thanks for your review.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/