Re: [PATCH] ACPI: do not mark TSC unstable for invalid C-states

[Thomas Gleixner]

On Thu, 14 May 2009, Len Brown wrote:

> hang on, that patch will fail for the case where valid
> is (about to be) set to 1 and we'll fail to disable the TSC
> for systems which _do_ have c3.  I'll send an updated patch shortly.

Yep, you are right. I missed the cx->valid update in
apic_processor_power_verify_cX(). So my patch would break the laptops
instead of breaking desktops and servers :)

Moving it to acpi_timer_check_state() is the best we can do and that
saves us ifdeffery as well as acpi_timer_check_state() is already x86
only.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/