Re: [PATCH -mm] vmscan: make mapped executable pages the firstclass citizen

[Wu Fengguang]

On Tue, May 12, 2009 at 09:20:11PM +0800, Rik van Riel wrote:
> Wu Fengguang wrote:
> 
> >> Also, the change makes this comment:
> >>
> >> 	spin_lock_irq(&zone->lru_lock);
> >> 	/*
> >> 	 * Count referenced pages from currently used mappings as
> >> 	 * rotated, even though they are moved to the inactive list.
> >> 	 * This helps balance scan pressure between file and anonymous
> >> 	 * pages in get_scan_ratio.
> >> 	 */
> >> 	reclaim_stat->recent_rotated[!!file] += pgmoved;
> >>
> >> inaccurate.
> > 
> > Good catch, I'll just remove the stale "even though they are moved to
> > the inactive list".
> 
> Well, it is still true for !VM_EXEC pages.

This comment?

        Count referenced pages from currently used mappings as rotated, even
        though only some of them are actually re-activated. This helps...

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/