Re: [KVM PATCH v2 2/4] kvm: add return value to kvm_io_bus_register_dev
From: Avi Kivity
Date: Sun May 17 2009 - 16:10:40 EST
Gregory Haskins wrote:
Today this function returns void and will internally BUG_ON if it fails.
We want to create dynamic MMIO/PIO entries driven from userspace later in
the series, so enhance this API to return an error code on failure.
We also fix up all the callsites to check the return code and BUG_ON if
it fails.
The net result should be identical behavior both before and after this
patch. We are simply laying the groundwork for the dynamic usage
What happens if the dynamic user gets in there first, then the internal
device (which is set up by userspace)? We'll just BUG().
Need to handle the failure gracefully, more or less.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/