Re: [PATCH] Fix print out of function which called WARN_ON()

[Linus Torvalds]

On Sun, 17 May 2009, Hugh Dickins wrote:
> 
> No, not sure at all, that was just a conclusion I jumped to.
> Though I think I was seeing it on x86-32 too.

Ok, the 32-bit calling convention doesn't do any of that, even though we 
compile the kernel with -mregparm=3. Any function with varargs arguments 
gets all arguments passed on the stack, and we just pass the frame pointer 
along, so there's no extra buffers.

So if you saw it on x86-32, then I think the only empty hole is indeed 
due to that 'char function[KSYM_SYMBOL_LEN]' (and whatever stack alignment 
code gcc does). And yes, it should be much better now.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/