Re: [PATCH] regulator: da903x: add missing __devexit_p()

[Eric Miao]

On Sat, May 16, 2009 at 2:50 AM, Mike Frysinger <vapier@xxxxxxxxxx> wrote:
> The remove function uses __devexit, so the .remove assignment needs
> __devexit_p() to fix a build error with hotplug disabled.
>
> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
> CC: Liam Girdwood <lrg@xxxxxxxxxxxxxxx>
> CC: Mike Rapoport <mike@xxxxxxxxxxxxxx>
> CC: Eric Miao <eric.miao@xxxxxxxxxxx>

Yes, Acked.

> ---
> Âdrivers/regulator/da903x.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
> index 72b1549..c6628f5 100644
> --- a/drivers/regulator/da903x.c
> +++ b/drivers/regulator/da903x.c
> @@ -497,7 +497,7 @@ static struct platform_driver da903x_regulator_driver = {
> Â Â Â Â Â Â Â Â.owner Â= THIS_MODULE,
> Â Â Â Â},
>    Â.probe     Â= da903x_regulator_probe,
> -    .remove     = da903x_regulator_remove,
> +    .remove     = __devexit_p(da903x_regulator_remove),
> Â};
>
> Âstatic int __init da903x_regulator_init(void)
> --
> 1.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/