Re: [Patch] Remove debugfs entries on bad path

From: Li Zefan
Date: Mon May 18 2009 - 21:13:20 EST


A better title:
[Patch] blktrace: remove debugfs entries on bad path

Stefan Raspl wrote:
> debugfs directory entries for devices are not removed on bad path.

Can you be more elaborate on how to reproduce this issue?

> If so, subsequent attempts to start blktrace on the respective
> devices will not succeed due to existing directories.
>
> Signed-off-by: Stefan Raspl <stefan.raspl@xxxxxxxxxxxxxxxxxx>
>
> ---
> kernel/trace/blktrace.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -262,6 +262,7 @@ static void blk_trace_free(struct blk_tr
> {
> debugfs_remove(bt->msg_file);
> debugfs_remove(bt->dropped_file);
> + debugfs_remove(bt->dir);
> relay_close(bt->rchan);
> free_percpu(bt->sequence);
> free_percpu(bt->msg_data);
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/