Re: [RFC][PATCH] convert block trace points to TRACE_EVENT()

[Christoph Hellwig]

On Tue, May 19, 2009 at 08:59:29AM -0400, Jeff Moyer wrote:
> I'm not sure I'm comfortable with this.  Having had to diagnose
> performance problems using blktrace, I find the dev_t information for
> plugs and unplugs especially interesting.  Maybe we can still figure
> this out given the context in the trace, though.  Can you comment on
> that?

The problem is that right now we still allow request queues shared by
multiple gendisks, so we can't get at the gendisk.  The blktrace ioctl
interface gets around that by doing the setup with an ioctl on the
block device node and storing the dev_t at that point.

But I don't think we actually have any drivers left sharing a queue
that way, and I'd love to get rid of that for various reasons.

> from the single letter output to the verbose strings?  Am I just being a
> curmudgeon?
> 
> I have one further question, which will expose my ignorance on this
> implementation.  Would the proposed patch change the information
> available to the blktrace utility,

That's the output from /sys/kernel/debug/tracing/trace when the
block events are enabled.  The blktrace utility should continue to
work without changes, although it could be ported to use the ftrace
binary ring buffer directly in the future.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/