RE: [PATCH] ACPICA: Eliminate double call toacpi_ns_get_parent_node in acpi_get_parent

[Moore, Robert]

I will integrate this into ACPICA.

Thanks,
Bob


>-----Original Message-----
>From: Alex Chiang [mailto:achiang@xxxxxx]
>Sent: Monday, May 18, 2009 8:23 PM
>To: lenb@xxxxxxxxxx
>Cc: linux-acpi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Moore, Robert
>Subject: [PATCH] ACPICA: Eliminate double call to acpi_ns_get_parent_node
>in acpi_get_parent
>
>Cache the value of the parent node so we don't have to look it up twice.
>
>Cc: Robert Moore <robert.moore@xxxxxxxxx>
>Signed-off-by: Alex Chiang <achiang@xxxxxx>
>---
>
> drivers/acpi/acpica/nsxfobj.c |    8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/acpi/acpica/nsxfobj.c b/drivers/acpi/acpica/nsxfobj.c
>index 1c7efc1..1cd8f15 100644
>--- a/drivers/acpi/acpica/nsxfobj.c
>+++ b/drivers/acpi/acpica/nsxfobj.c
>@@ -161,7 +161,7 @@ ACPI_EXPORT_SYMBOL(acpi_get_type)
>
>***************************************************************************
>***/
> acpi_status acpi_get_parent(acpi_handle handle, acpi_handle * ret_handle)
> {
>-	struct acpi_namespace_node *node;
>+	struct acpi_namespace_node *node, *parent_node;
> 	acpi_status status;
>
> 	if (!ret_handle) {
>@@ -189,12 +189,12 @@ acpi_status acpi_get_parent(acpi_handle handle,
>acpi_handle * ret_handle)
>
> 	/* Get the parent entry */
>
>-	*ret_handle =
>-	    acpi_ns_convert_entry_to_handle(acpi_ns_get_parent_node(node));
>+	parent_node = acpi_ns_get_parent_node(node);
>+	*ret_handle = acpi_ns_convert_entry_to_handle(parent_node);
>
> 	/* Return exception if parent is null */
>
>-	if (!acpi_ns_get_parent_node(node)) {
>+	if (!parent_node) {
> 		status = AE_NULL_ENTRY;
> 	}
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/