Re: Rgeression: 2.6.30-rc6-git3 build error - ICE fromdrivers/char/random.c

From: Ingo Molnar
Date: Wed May 20 2009 - 03:53:49 EST



* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, 19 May 2009, Linus Torvalds wrote:
> >
> > I guess getting rid of 'jiffies' is also worth it. Even at its very worst,
> > 'get_cycles()' should return jiffy-level information, so adding in jiffies
> > doesn't add anything to it.
>
> I take that back. If there isno TSC at all, "get_cycles()" might
> just be returning zero. So the jiffies fallback is probably better
> than nothing.
>
> So I'll just remove the (long)&ret part. [...]

I suspect we could add current_thread_info() or 'current' to it - as
they are initialized variables. (which the stack pointer mostly
boils down to - the stack depth is predictable)

Not worth the trouble though i suspect.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/