Re: [PATCH v2 2/2] Intel-IOMMU, intr-remap: source-id checking

[Eric W. Biederman]

Ingo Molnar <mingo@xxxxxxx> writes:

>> The table of apic information by apic_id also seems wrong.  Don't 
>> we have chip_data or something that should point it that we can 
>> get from the irq?
>
> ->chip_data is already used for io-apic configuration bits - if it's 
> reused then the right way to do it is to extend struct irq_cfg in 
> arch/x86/kernel/apic/io_apic.c.

We are talking about some extra io-apic configuration bits, that
happen to currently be private to dmar.c.

chip_data, handler_data I can never keep those straight except
when I am deep in the code.  What I do know is that encouraging
more arrays of size MAX_IO_APICS seems like the wrong direction.

Which probably means adding the information we need to struct irq_cfg.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/