Re: [PATCH 01/20] sysfs: Implement sysfs_rename_link

[Tejun Heo]

Hello,

Eric W. Biederman wrote:
> +int sysfs_rename_link(struct kobject *kobj, struct kobject *targ,
> +			const char *old, const char *new)
> +{
> +	sysfs_remove_link(kobj, old);
> +	return sysfs_create_link(kobj, targ, new);
> +}
> +

Removal and creation are done in the reverse order compared to the one
used in device rename.  The important difference is that previously
failed operation was noop whereas it now would remove the current
link.  I think the old order is correct.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/