Re: [PATCH 15/20] sysfs: Kill sysfs_addrm_start and sysfs_addrm_finish

From: Tejun Heo
Date: Thu May 21 2009 - 05:31:28 EST


Eric W. Biederman wrote:
> From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
>
> With lazy inode updates and dentry operations bringing everything
> into sync on demand there is no longer any need to immediately
> update the vfs or grab i_mutex to protect those updates as we
> make changes to sysfs.
>
> So stop updating the vfs inodes and move what remains of
> sysfs_addrm_start and sysfs_addrm_finsih (just barely more than taking
> the sysfs_mutex) into sysfs_add_one and sysfs_remove_one.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxxxxxxxx>

This looks so better than the original code. :-)

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/