Re: [PATCH] driver core : fix request_firmware_nowait

From: Ming Lei
Date: Fri May 22 2009 - 11:26:28 EST


2009/5/22 Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>:
> On Fri, 22 May 2009 23:06:27 +0800
> tom.leiming@xxxxxxxxx wrote:
>
>> From: Ming Lei <tom.leiming@xxxxxxxxx>
>>
>> request_firmware_nowait declares it can be called in non-sleep contexts,
>> but kthead_run which is called by request_firmware_nowait may sleep.
>
> Does anyone actually need to call it in a non-sleeping context or can the
> documentation simply be fixed instead to avoid all the extra complexity ?
>

It seems no one calls it in a non-sleeping context now, but we can provide it
without much extra complexity, IMHO. Also someone has complained it :

http://marc.info/?t=124022846400003&r=1&w=2

--
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/