Re: [BUG FIX] Make x86_32 uni-processor Atomic ops, Atomic

From: Ingo Molnar
Date: Fri May 22 2009 - 14:36:46 EST



* Michael S. Zick <lkml@xxxxxxxxxxxx> wrote:

> Found in the bit-rot for 32-bit, x86, Uni-processor builds:
>
> diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h
> index f6aa18e..3c790ef 100644
> --- a/arch/x86/include/asm/alternative.h
> +++ b/arch/x86/include/asm/alternative.h
> @@ -35,7 +35,7 @@
> "661:\n\tlock; "
>
> #else /* ! CONFIG_SMP */
> -#define LOCK_PREFIX ""
> +#define LOCK_PREFIX "\n\tlock; "
> #endif

What is your motivation for this change? At first sight this makes
the UP kernel a bit larger and a bit smaller. Are you fixing some
real regression/bug here?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/