Re: [PATCH 2/2] firewire: core: add sysfs attribute for easier udevrules

[Stefan Richter]

Stefan Richter wrote:
> +	while (fw_csr_iterator_next(&ci, &key, &value)) {
> +		if (key != (CSR_UNIT | CSR_DIRECTORY))
> +			continue;
> +		i += units_sprintf(&buf[i], ci.p + value - 1);
> +		if (i >= PAGE_SIZE - (8 + 1 + 8 + 1))
> +			break;
> +	}
> +	up_read(&fw_device_rwsem);
> +
> +	sprintf(&buf[i ? i - 1 : 0], "\n");

Rather:
	if (i)
		buf[i - 1] = '\n';
> +
> +	return i;
> +}
--
Stefan Richter
-=====-==--= -=-= =-===
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/