Re: [PATCH] firmware: Allocate firmware id dynamically

[Stephen Rothwell]

Hi all,

On Tue, 26 May 2009 13:23:51 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > > Please note that we have to keep the FIRMWARE_NAME_MAX definition around as
> > > some drivers rely on it.
> > 
> > I think the 6 files should be converted, and FIRMWARE_NAME_MAX
> > removed, otherwise people will keep copying that crap around.
> > 
> >   drivers/pcmcia/ds.c
> >   drivers/usb/atm/ueagle-atm.c
> >   drivers/net/wireless/libertas/if_usb.c
> >   drivers/net/wireless/libertas/if_spi.c
> >   drivers/media/dvb/dvb-usb/dvb-usb.h
> >   drivers/media/common/tuners/tuner-xc2028.c
> 
> Yep.

$ git grep -l -w FIRMWARE_NAME_MAX next-20090526 
next-20090526:drivers/base/firmware_class.c
next-20090526:drivers/media/common/tuners/tuner-xc2028.c
next-20090526:drivers/media/dvb/dvb-usb/dvb-usb.h
next-20090526:drivers/net/wireless/libertas/if_spi.c
next-20090526:drivers/net/wireless/libertas/if_usb.c
next-20090526:drivers/net/wireless/p54/p54usb.c
next-20090526:drivers/pcmcia/ds.c
next-20090526:drivers/usb/atm/ueagle-atm.c
next-20090526:include/linux/firmware.h
next-20090526:samples/firmware_class/firmware_sample_firmware_class.c

Its already started ...

/me looks forward to more breakage in -next :-(
-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature