Re: parport_pc: Fix subscription bugs

[Alan Cox]

On Mon, 1 Jun 2009 11:00:33 +0200
Michael Buesch <mb@xxxxxxxxx> wrote:

> This patch fixes array subscription bugs in the parport_pc driver.
> 
> drivers/parport/parport_pc.c: In function âparport_irq_probeâ:
> drivers/parport/parport_pc.c:1589: warning: array subscript is above array bounds
> drivers/parport/parport_pc.c: In function âparport_pc_probe_portâ:
> drivers/parport/parport_pc.c:1579: warning: array subscript is above array bounds
> 
> The patch also fixes a few other array bugs, which the compiler was
> unable to find. Coding style violations are also fixed.

Which makes it very hard to see what you are actually changing and
whether it is a bug. It certainly looks like one but the changes muddled
in with a random subset of format fixes (even in the area patched only
some style is fixed) looks pretty clunky - surely a for() loop would be
far cleaner.


But yes agreed - its a bug, it wants fixing and style can be sorted later.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/